Linear reachability, take 2 #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmcsherry
force-pushed
the
linear_reachability_2
branch
from
7d8c5c4 to
4929372
Compare
frankmcsherry
force-pushed
the
linear_reachability_2
branch
2 times, most recently
from
fcbac30 to
b4ef9b2
Compare
frankmcsherry
force-pushed
the
linear_reachability_2
branch
from
b4ef9b2 to
f8a234a
Compare
antiguru
approved these changes
Mar 26, 2025
Member
antiguru
left a comment
antiguru
left a comment
There was a problem hiding this comment.
Looks good; left one inline comment.
Co-authored-by: Moritz Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly building up more confidence in changing our internal operator reachability implementation. This is a more careful version of #651, which in particular avoids a shadowing bug that seemed to be at the root of #654.
The external facing changes are that customer operator input/output creation no longer take a
Vec<Antichain<_>>, but rather anI: IntoIterator<Item=(usize, Antichain<_>)>. This allows a sparse description of connectivity, in cases where it would be expensive to produce a large number ofAntichain::default()empty antichains.The new behavior is scale-tested in
tests/shape_scaling.rs, where we test operators and subgraphs up to 100,000 x 100,000.